search

ec-jrc / lisflood-code

Lisflood OS - LISFLOOD
https://ec-jrc.github.io/lisflood
European Union Public License 1.2
122 stars 50 forks source link

to remove TEMPORARY WORKAROUND FOR EFAS XDOM in routing.py #6

Closed domeniconappo closed 3 years ago

domeniconappo commented 5 years ago

We don't need this line after new calibration is completed

self.var.QLimit = self.var.QLimit / 24.0
domeniconappo commented 5 years ago

There is a commit to not accept: b0315b164f0d732061609ffbd5ce7210e221f3b9.

We need to keep old version until new hprot calibration is completed for EFAS.

self.var.Sideflow1Chan = np.where(self.var.ChanM3Kin > self.var.M3Limit, SideflowRatio*SideflowChan, SideflowChan)

When it's done, we have to accept the new formula from @ecCinziaMazzetti 

self.var.Sideflow1Chan = np.where((self.var.ChanM3Kin + self.var.Chan2M3Kin-self.var.Chan2M3Start) > self.var.M3Limit, SideflowRatio*SideflowChan, SideflowChan)
domeniconappo commented 4 years ago

Included fixes from #55 into #61 (still under test).