ec-jrc / lisflood-usecases

Lisflood Test Catchments use cases
European Union Public License 1.2
16 stars 11 forks source link

Water Depth units in ETRS89 use case #15

Open UFelarson opened 7 months ago

UFelarson commented 7 months ago

The output variable wdept has units of meters. However, the values, up to 50, do not suggest these are accurate units. Furthermore, the supporting data such as rainfall and runoff do not support such high water depths. Finally, this table https://ec-jrc.github.io/lisflood-code/4_annex_settings_and_options/ indicates that (mm) is the correct unit. Can someone confirm the units on this variable, and if it is meters, potentially explain why the values are so large? Thanks, Erik

StefaniaGrimaldi commented 7 months ago

Dear @UFelarson,

thank you for your enquiry: the correct units are mm (https://github.com/ec-jrc/lisflood-code/blob/419df0a255096671a7ea3b3b29ff2dfb9b42f281/src/lisflood/hydrological_modules/surface_routing.py#L203). There is indeed an error in the metadata of the output files: thank you for reporting this error. We will fix it in the next OS LISFLOOD release.

Kind regards, on behalf of the developers team, Stefania