search

ec-jrc / lisflood-utilities

LISFLOOD OS - Utilities
https://ec-jrc.github.io/lisflood
European Union Public License 1.2
22 stars 9 forks source link

Bugfix/cftime #28

Closed corentincarton closed 2 years ago

corentincarton commented 2 years ago

Just a small bug fix to support cftime (for newer versions of netcdf/pandas). I also fixed a part of test_cutmaps that was not compatible with the new api... but I bumped into another issue in Xarray. @doc78, we are not using directly this in our workflow so I don't want to mess it up... but this is not compatible with more recent versions of netcdf/xarray.

doc78 commented 2 years ago

Fixes are ok but not really needed since in requirements.txt the version of cftime is still fixed to the cftime==1.0.4.2. However these fixes should be included when we merge the branch cutmaps_catchments, where requirements,txt allows updated packages.

corentincarton commented 2 years ago

@doc78 , thanks! I just ran the cutmaps_catchments branch and it's all good. I'll delete that branch and the associated PR then.

corentincarton commented 2 years ago

@corentincarton ah wait, we still need the date thingy for lisflood. I updated the PR to point to the cutmaps_catchments branch