search

ec-jrc / lisflood-utilities

LISFLOOD OS - Utilities
https://ec-jrc.github.io/lisflood
European Union Public License 1.2
22 stars 9 forks source link

add thresholds utility #32

Closed corentincarton closed 1 year ago

corentincarton commented 1 year ago

Adding the thresholds script that we used to compute the return period thresholds for EFAS 5.0 and GloFAS 4.0.

corentincarton commented 1 year ago

@doc78 and @StefaniaGrimaldi, I'll add a unit test and update the Readme. I still need to remove the legacy folder as well.

corentincarton commented 1 year ago

@doc78 and @StefaniaGrimaldi, I updated the readme and added some unit tests. Don't hesitate to tell me if something's missing!

corentincarton commented 1 year ago

Yes, I agree! I didn’t put that in the script as for massive dataset, it becomes a challenge.

From: StefaniaGrimaldi @.> Sent: Friday, May 5, 2023 3:38:25 PM To: ec-jrc/lisflood-utilities @.> Cc: Corentin Carton De Wiart @.>; Mention @.> Subject: Re: [ec-jrc/lisflood-utilities] add thresholds utility (PR #32)

@StefaniaGrimaldi approved this pull request.

Thanks @corentincartonhttps://github.com/corentincarton!

Since LISFLOOD does not provide yearly maximum as output variable, we could suggest to post-process the dis.nc LISFLOOD output file using CDO.

Please see below my proposal:

"Usage The tool takes as input a Netcdf file containing the annual maxima of the discharge signal. LISFLOOD computes time series of discharge values (average value over the selected computational time step). The users are therefore required to compute the annual maxima. As an example, this step can be achieved by using CDO (cdo yearmax), for all the details please refer to https://code.mpimet.mpg.de/projects/cdo/embedded/index.html#x1-190001.2.5"

What do you think?

— Reply to this email directly, view it on GitHubhttps://github.com/ec-jrc/lisflood-utilities/pull/32#pullrequestreview-1414927065, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADXPG4ZQHF7I3EJT4NOE2P3XEUGGDANCNFSM6AAAAAAWD5AAFY. You are receiving this because you were mentioned.Message ID: @.***>