search

ec-jrc / lisflood-utilities

LISFLOOD OS - Utilities
https://ec-jrc.github.io/lisflood
European Union Public License 1.2
22 stars 9 forks source link

Add return period computation #38

Closed MclTTI closed 1 year ago

MclTTI commented 1 year ago

Building on thresholds.py, a number of utilities have been added to calculate the return period of a precipitation field. lmoments.py contains the old and a new function to calculate the L-moments estimators of a data distribution. distr_params.py calculates the parameters of an Extreme-Value distribution (user can choose between GEV and Gumbel) using the L-moments estimators. return_period.py uses the parameters from distr_params.py to compute the return period of the input field.

StefaniaGrimaldi commented 1 year ago

Dear @MclTTI ,

we noticed this closed pull request and we would like to ask you whether you are interested in discussing the possibility of contributing to the open-source repository.

Contributions to OS LISFLOOD repositories are highly welcome. Nevertheless, there are some essential requirements such as verification of compatibility with the existing scripts and functionalities (via the test suite), adequate documentation, inclusion of a dedicated new test.

We can discuss this further in this issue or via email (Stefania.GRIMALDI@ec.europa.eu). Kind regards, Stefania

MclTTI commented 1 year ago

Hi Stefania,

I confirm my interest in contributing to the lisflood repo, as I am still working on it, extending some script that I intend to apply in my current research. I will be happy to discuss testing and compatibility with the existing code. Please let me know how we can discuss this further.

Best, Marcello

From: StefaniaGrimaldi @.> Date: Friday, 28 July 2023 at 07:17 To: ec-jrc/lisflood-utilities @.> Cc: MclTTI @.>, Mention @.> Subject: Re: [ec-jrc/lisflood-utilities] Add return period computation (PR #38)

Dear @MclTTIhttps://github.com/MclTTI ,

we noticed this closed pull request and we would like to ask you whether you are interested in discussing the possibility of contributing to the open-source repository.

Contributions to OS LISFLOOD repositories are highly welcome. Nevertheless, there are some essential requirements such as verification of compatibility with the existing scripts and functionalities (via the test suite), adequate documentation, inclusion of a dedicated new test.

We can discuss further in this issue or via email @.**@.>). Kind regards. Stefania

— Reply to this email directly, view it on GitHubhttps://github.com/ec-jrc/lisflood-utilities/pull/38#issuecomment-1655094935, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMDFS7MBILERAZPOX3HLQLDXSNKQPANCNFSM6AAAAAA2TC56HQ. You are receiving this because you were mentioned.Message ID: @.***>

StefaniaGrimaldi commented 1 year ago

Dear @MclTTI,

we are very pleased to know that you are willing to contribute to LISFLOOD OS repositories.

I suggest discussing the details via a video call. I will send you a Doodle to set up a meeting via email.

Stefania