ec-jrc / pyPoseidon

Framework for Hydrodynamic simulations
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
20 stars 8 forks source link

Investigate replacing pydap with another library #127

Closed pmav99 closed 1 year ago

pmav99 commented 1 year ago

Since pydap 3.3.0 does not get released, we should investigate whether we can remove it as a dependency.

We have a test that uses pydap:

pytest -vlx tests/test_meteo.py --runslow -k url

The relevant code is:

$ ag pydap --python

pyposeidon/meteo.py
315:    # xr_kwargs = kwargs.get("meteo_xr_kwargs", {"engine": "pydap"})
brey commented 1 year ago

I would open an issue in xarray asking how they see the support of pydap going forward.

brey commented 1 year ago

@pmav99 Is this still an issue? Isn't there a pypi release already?

pmav99 commented 1 year ago

Yes there is a new release. We can close.