search

ec-jrc / pyPoseidon

Framework for Hydrodynamic simulations
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
20 stars 8 forks source link

cast: read model from path/str Raises exception #142

Closed pmav99 closed 1 year ago

pmav99 commented 1 year ago 
import pandas as pd

from pyposeidon.utils import cast

rs = cast.set(
    solver_name='schism',
    model="/scratch/shared/20220901.00/schism_model.json",
    ppath="/scratch/shared/20220901.00/",
    cpath="/scratch/shared/20220901.12/",
    meteo="../20220901.12.uvp_72.grib",
    sdate=pd.to_datetime("2022-09-01 12:00:00"),
)

rs.run(execute=False)

Throws:

Traceback (most recent call last):
  File "create_next_step.py", line 15, in <module>
    rs.run(execute=False)
  File "/mnt/mambaforge/envs/pyposeidon_env/lib/python3.8/site-packages/pyposeidon/utils/cast.py", line 225, in run
    self.model = pyposeidon.read_model(self.model)
AttributeError: module 'pyposeidon' has no attribute 'read_model'

It seems that read_model() is no longer defined (at least in current dev branch). The references need to be updated

$ ag `read_model`

pyposeidon/utils/features.py
38:    m = pyposeidon.read_model(path + tag + "_model.json")

pyposeidon/utils/cast.py
52:            self.model = pyposeidon.read_model(self.model)
225:            self.model = pyposeidon.read_model(self.model)