Open pmav99 opened 1 year ago
just adding the parameters dict gives:
Do you think it's ok?
I guess that the difference is that the dictionary is coupled with pyPoseidon, while the param.nml is coupled with schism. Both should work.
On second thought, a potential issue with the dictionary is that if there is a bug or even an update in pyPoseidon the dictionary might not be directly usable. You will need to track the version of pyPoseidon, too, in order to recreate the param.nml. With the param.nml there will be no such problems.
Another option would be to add both files. Metadata are cheap :)
You mean add the param.nml
as json
? How else can you add it?
I assume you can add it as a string.
I just checked an ADCIRC output file and its global attributes are like these:
I think it can be useful to have the param.nml contents as netcdf metadata. It shouldn't be too difficult to add this info when we merge the data.
@brey thoughts?