ec-jrc / pyPoseidon

Framework for Hydrodynamic simulations
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
20 stars 7 forks source link

Consolidate launchSchism.sh execution and handling of ABORT #155

Closed pmav99 closed 1 year ago

pmav99 commented 1 year ago

When the input data is malformed, schism is throwing ABORT, MPI_ABORT but, in certain cases, returns a status code of 0. Therefore, in order to figure out if schism's execution failed we need to check the STDOUT/STDERR, too. Until now we were doing this in the python code but since we were doing this in multiple places (e.g. schism.py and mesh.py) there is some code-duplication.

We should try to move the tests for ABORT to launchSchism.sh and we should also try to consolidate the execution of launchSchism.sh so that it happens using the same API.