When the input data is malformed, schism is throwing ABORT, MPI_ABORT but, in certain cases, returns a status code of 0. Therefore, in order to figure out if schism's execution failed we need to check the STDOUT/STDERR, too. Until now we were doing this in the python code but since we were doing this in multiple places (e.g. schism.py and mesh.py) there is some code-duplication.
We should try to move the tests for ABORT to launchSchism.sh and we should also try to consolidate the execution of launchSchism.sh so that it happens using the same API.
When the input data is malformed, schism is throwing ABORT, MPI_ABORT but, in certain cases, returns a status code of 0. Therefore, in order to figure out if schism's execution failed we need to check the STDOUT/STDERR, too. Until now we were doing this in the python code but since we were doing this in multiple places (e.g.
schism.py
andmesh.py
) there is some code-duplication.We should try to move the tests for ABORT to
launchSchism.sh
and we should also try to consolidate the execution oflaunchSchism.sh
so that it happens using the same API.