search

ec-jrc / pyPoseidon

Framework for Hydrodynamic simulations
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
20 stars 8 forks source link

schism: Fix stmp attributes in sflux files. #178

Closed pmav99 closed 6 months ago

pmav99 commented 6 months ago

I think the units for time is also wrong. It should be

        float time(time) ;
                time:long_name = "Time" ;
                time:standard_name = "time" ;
                time:units = "days since 2001-01-01" ;
                time:base_date = 2001, 1, 1, 0 ;

while it is set like this:

    double time(time) ;
        time:long_name = "Time" ;
        time:standard_name = "time" ;
        time:base_date = 2018LL, 10LL, 1LL, 0LL ;
        time:units = "2018-10-01" ;

The relevant code is: https://github.com/ec-jrc/pyPoseidon/blob/9cfd3bbf5598c810004def83b1f43dc5149addd0/pyposeidon/schism.py#L291-L324