search

ec-jrc / pyPoseidon

Framework for Hydrodynamic simulations
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
20 stars 8 forks source link

mesh: Rename "node" to "bnode" #184

Open pmav99 opened 6 months ago

pmav99 commented 6 months ago

@brey would it be possible to rename node to bnode or something?

image

node is kind of too generic. And it does conflict with e.g. thalassa naming scheme (probably with other naming schemes too). I don't really know what other changes we would need to make though.

brey commented 6 months ago

Can you propose one name. It shouldn't be difficult to do. I can include it in the next PR.

tomsail commented 2 months ago

node should be renamed boundary_node_connectivity

http://ugrid-conventions.github.io/ugrid-conventions/conformance/#R114