ec-jrc / re3gistry

Re3gistry is a reusable open source solution for managing and sharing ‘reference codes’, ensuring semantic interoperability across organisations.
European Union Public License 1.2
27 stars 21 forks source link

Re3gistry 2.5.2 restapi error #428

Open TeijoKal opened 1 month ago

TeijoKal commented 1 month ago

Notice some not so good behaviour when using restapi.

In our 1.3.1 production environment:

https://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211/211.en.json { "value": { "id": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211", "thisversion": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211:2", "latestversion": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211", "historyversion": [ { "version": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211:1" } ], "language": "en", "label": { "lang": "fi", "text": "Kiinnike tai tuki voimajohtoa varten" }, "description": { "lang": "fi", "text": "Lakannut 1999-12-31" }, "itemclass": { "id": "CodeListValue", "label": { "lang": "en", "text": "Code list value" } }, "status": { "id": " http://www.luettelopalvelu.fi/registry/status/retired", "label": { "lang": "en", "text": "Retired" } }, "register": { "id": "http://www.luettelopalvelu.fi/codelist", "label": { "lang": "en", "text": "INSPIRE code list register" }, "registry": { "id": "http://www.luettelopalvelu.fi/registry", "label": { "lang": "en", "text": "INSPIRE registry" } } }, "codelist": { "id": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji", "label": { "lang": "fi", "text": "KTJkii käyttöoikeusyksikkölaji" } } } }

But then i tried the following in our demo (Re3gistry 2.5.2) environment:

https://dev.luettelopalvelu.fi/registry/rest?lang=en&uri=http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211&format=json

{ "value": { "itemclass": { "label": { "text": "Codelist", "lang": "en" }, "id": "Codelist" }, "created": "2023-10-27 10:58 AM EEST", "language": "en", "definition": { "text": "

Keskussairaalat

", "lang": "fi" }, "id": "http://dev.luettelopalvelu.fi/codelist/RakennuksenTarkkaKayttotarkoitus/211", "label": { "text": "Keskussairaalat", "lang": "fi" }, "latestversion": "http://dev.luettelopalvelu.fi/codelist/RakennuksenTarkkaKayttotarkoitus/211", "thisversion": "http://dev.luettelopalvelu.fi/codelist/RakennuksenTarkkaKayttotarkoitus/211:1", "status": { "label": { "text": "Valid", "lang": "en" }, "id": "statusbaseuri/status/valid" }, "register": { "registry": { "label": { "text": "Luettelopalvelu", "lang": "fi" }, "id": "http://dev.luettelopalvelu.fi/registry" }, "label": { "text": "INSPIRE-koodiluettelorekisteri", "lang": "fi" }, "id": "http://dev.luettelopalvelu.fi/codelist" } } }

And it returned wrong data! I checked why this happened and it seems that because the data was not in our dev environment (KTJkiiKayttooikeusyksikkolaji and code value 211). After i added the entry of code value 211 it showed the correct result.

But the question is why it send some other answer that was not asked but the code value was the same 211??? And did not send any error message ??

https://dev.luettelopalvelu.fi/registry/rest?lang=en&uri=http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211&format=json

{ "value": { "itemclass": { "label": { "text": "Codelist", "lang": "en" }, "id": "Codelist" }, "codelist": { "label": "", "id": "" }, "created": "2024-05-30 05:59 AM EEST", "language": "en", "definition": { "text": "

Kiinnike tai tuki voimajohtoa varten

", "lang": "fi" }, "id": "http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211", "label": { "text": "Kiinnike tai tuki voimajohtoa varten", "lang": "fi" }, "latestversion": "http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211", "thisversion": "http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211:1", "status": { "label": { "text": "Valid", "lang": "en" }, "id": "statusbaseuri/status/valid" }, "register": { "registry": { "label": { "text": "Luettelopalvelu", "lang": "fi" }, "id": "http://dev.luettelopalvelu.fi/registry" }, "label": { "text": "INSPIRE-koodiluettelorekisteri", "lang": "fi" }, "id": "http://dev.luettelopalvelu.fi/codelist" } } }

iratigarzon commented 1 month ago

Dear @TeijoKal,

Thank you for bringing this to our attention. We will look into it.

Best regards,

Irati.

TeijoKal commented 3 days ago

Did you managed to reproduce the error? Do you have any estimate yet to the fix? This error is only prohibiting to move this version 2 to our production environment.