search

ecadlabs / signatory

Signatory - A Tezos Remote Signer for signing block-chain operations with private keys using YubiHSM, AWS, GCP, Ledger's or Azure Key Vault
https://signatory.io
Apache License 2.0
61 stars 18 forks source link

Upgrade go to version v1.21.0 and all dependencies #433

Closed danielelisi closed 1 year ago

danielelisi commented 1 year ago

As per title.

Go v1.21.0 was released so I upgraded goreleaser-cross to the latest version to use the latest version of Go. Since goreleaser-cross:v1.21.0 isn't available on Dockerhub registry I pointed the image to GHCR which has v1.21.0 already available.

I've also upgraded all dependencies to their latest versions with

$ go get -u ./...
$ go mod tidy
cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 888f2d4
Status: ✅  Deploy successful!
Preview URL: https://06808063.signatory.pages.dev
Branch Preview URL: https://upgrade-go-121.signatory.pages.dev

View logs

stephengaudet commented 1 year ago

also, FWIW, 1.21.0 is also available on docker hub now, so, both registries would work now

danielelisi commented 1 year ago

I think we need: steps: - uses: actions/setup-go@v3 with: go-version: '1.21.0'

on jobs {test, integration-tests,report-coverage} anywhere that we call go, so that we are sure to be testing and building coverage reports with the same version of go that goreleaser-cross is building with

Thanks for catching this

danielelisi commented 1 year ago

also, FWIW, 1.21.0 is also available on docker hub now, so, both registries would work now

Ah yes I just checked. Might as well we stick with ghcr.io if updated images are released faster there