ecadlabs / taquito

A library for building dApps on the Tezos Blockchain - JavaScript / TypeScript
https://taquito.io
Apache License 2.0
298 stars 116 forks source link

Use true private methods fields #1184

Open jimmywarting opened 2 years ago

jimmywarting commented 2 years ago

https://github.com/ecadlabs/taquito/blob/77bf9da3bc4b72e9afce51c815f5ccd2a2a5580f/packages/taquito-signer/src/ed-key.ts#L10

everything not starting with # is simply public.

Example:

- private _publicKey: Uint8Array; 
+ #publicKey: Uint8Array; 
roxaneletourneau commented 2 years ago

thanks @jimmywarting Linking documentation here on “should I use the private keyword, or ECMAScript’s hash/pound (#) private fields?” : https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/#which-should-i-use

Innkst commented 2 years ago

@jimmywarting is there a specific issue that you are dealing with? Would be great to have more context about your use case. What are your thoughts on the above-linked document? Thank you