ecadlabs / taquito

A library for building dApps on the Tezos Blockchain - JavaScript / TypeScript
https://taquito.io
Apache License 2.0
298 stars 116 forks source link

Support SORU operations from Kathmandu #1953

Closed psmolinsky closed 1 year ago

psmolinsky commented 2 years ago

Taquito 14 already supports the Kathmandu protocol, but many SORU-related operations are missing (according to block schema). Can you please support them at least in @taquito/rpc?

Innkst commented 2 years ago

These were not added because SCORU is not officially supported till protocol M and may change. Is this blocking any particular work for you? @psmolinsky

psmolinsky commented 1 year ago

Hi, so Taquito 16 with Mumbai protocol support is out. However, it is still missing following operations. Why please?

dsawali commented 1 year ago

Hey there, the operations that you mentioned relies on communication from Taquito to L2.

Taquito as it stands right now remain an L1 library, so supporting them would require quite a large paradigm shift. While we aren't opposed to the change, we'd like to plan accordingly.

dsawali commented 1 year ago

I would probably have to add that when I said 'supporting' I meant support and features to inject said operations.

But we can definitely add support for Taquito to be able to read those ops from the node. @psmolinsky

psmolinsky commented 1 year ago

Hi @dsawali, I understand that adding L2 support is a bigger task. For me, it is completely enough to add these operations to RPC block as far as we are building indexer framework. Thanks.

dsawali commented 1 year ago

Awesome, thanks for understanding @psmolinsky. We'll create a ticket to update that and we'll keep you posted.

dsawali commented 1 year ago

created an issue for you to track here: https://github.com/ecadlabs/taquito/issues/2409

cc @psmolinsky

michaelkernaghan commented 1 year ago

This issue should be closed as it is replaced with this other newer issue here: https://github.com/ecadlabs/taquito/issues/2409