search

ecamp / ecamp3

eCamp v3 is a web-based app for camp and course planning. The application is specialized for camps and courses of youth associations and for Y+S offers in the sport of camp sports/trekking.
https://ecamp3.ch
GNU Affero General Public License v3.0
111 stars 49 forks source link

Wrong dirty handling for ApiColorPicker #4404

Closed usu closed 5 months ago

usu commented 8 months ago 
          @usu I couldn't easily fix the picker problem. I did manage to prevent an api request if the value changes from the outside. I think we could fix the dirty problem in a separate PR.

Originally posted by @manuelmeister in https://github.com/ecamp/ecamp3/issues/4328#issuecomment-1872218067

Problem not a problem with ApiColorPicker but either with BasePicker or with ApiWrapper in general.

The dirty handling has also been raised in the following issues, so it probably makes sense to look at it more holistically:

carlobeltrame commented 5 months ago

Fixed in #4761 (unless someone manages to reproduce still)