search

ecamp / ecamp3

eCamp v3 is a web-based app for camp and course planning. The application is specialized for camps and courses of youth associations and for Y+S offers in the sport of camp sports/trekking.
https://ecamp3.ch
GNU Affero General Public License v3.0
109 stars 48 forks source link

replace hard coded api urls with templated links #5168

Closed bb1950328 closed 2 weeks ago

bb1950328 commented 3 weeks ago

fixes #977 successfully tested by verifying that all mounted() functions are called at least once and checking that the api calls still work by doing the corresponding action in the ui

github-actions[bot] commented 2 weeks ago

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

pmattmann commented 2 weeks ago

Wouldn't this make sense to move these individual mounted definitions to the DialogBase and provide the key, as the mounted call is identical?

This PR exactly fulfills the issue #977 I therefore suggest that we merge this PR as it is - and that you create a new issue with your concern.