search

ecamp / ecamp3

eCamp v3 is a web-based app for camp and course planning. The application is specialized for camps and courses of youth associations and for Y+S offers in the sport of camp sports/trekking.
https://ecamp3.ch
GNU Affero General Public License v3.0
109 stars 48 forks source link

DRAFT: Create new color picker #5174

Open manuelmeister opened 2 weeks ago

manuelmeister commented 2 weeks ago

I tried to create a color field on the campCollaboration to be able to differentiate between users with (accidental) same colors. In the process of this, I realized that our colorpicker is not able to handle null values. I thought it would be best to implement the new colorpicker using the EParseField.

github-actions[bot] commented 2 weeks ago

Feature branch deployment ready!

Name Link
Deployment https://pr5174.ecamp3.ch/
Login test@example.com / test
Last deployed at Wed May 15 2024 19:50:09 GMT+0200
Latest commit 51078c03d93fdbc3c1233b3cafefe41bfe99d23c
Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/9100309240/job/25015077327
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
manuelmeister commented 2 weeks ago

@carlobeltrame sorry this is not yet fully reviewable. Of course my goal is to replace the other colorpicker and have it completed to parity with the current one. I'll notify you when I'm ready.

The old api-colorpicker apparently happily saves #asdfas as category color, and the category color input isn't displayed anymore from then on. Could we make sure to fix this in the new picker?

yes should be fixed

manuelmeister commented 2 weeks ago

@carlobeltrame I figured, I'd rather have a separate color field that has no popup, just a text field and add a separate component with the picker. As soon as I fixed the tests, I'll replace the old color picker with the new one.