search

ecampbell / moodle-atto_wordimport

Import Word file contents into Moodle Atto text box
2 stars 7 forks source link

Displaying WordImport button on the pre expanded toolbar breaks image DND upload #14

Open nadavkav opened 7 years ago

nadavkav commented 7 years ago

If I manage to display the WordImport button on the initial (short/minimal) Atto toolbar (before the user press the expand button to show more toolbars/button) than it blocks the user from being able to drag and drop images into the content area of the Atto editor (Moodle 3.1)

If I change the order of buttons display, and move it to the end of the buttons list, so it is only visible if the user click to expand the list of toolbars/button in the editor... then drag and drop of images works again.

No errors are displayed (weird bug)

ecampbell commented 7 years ago

As I have configured it, the WordImport button is automatically added to the initial toolbar. Are you seeing something different? Are you using Google Chrome? I believe there have been some issues with the image drag-and-drop in Google Chrome. Try testing on another browser.

nadavkav commented 7 years ago

I moved the auto inserted "wordimport" to the end - after the last button on the last extra toolbar. and it works fine. maybe it has some race condition with the Moodle core image DND functions? I am using Chrome. I will check other browsers. but it is a main browser for a lot of our users.

Anyways... what a beautiful and useful plugin! thank you for sharing it :smile:

ecampbell commented 7 years ago

Thanks for your kind words, I am quite proud of it! You might also be interested in the corresponding Word import plugin for Moodle books, https://moodle.org/plugins/booktool_wordimport, or the question format version https://moodle.org/plugins/qformat_wordtable. These plugins both support export to Word as well.

nadavkav commented 7 years ago

Thank you for pointing out the other plugins, I was only aware (and using) of the qformat_wordtable. (thought I have some issues with it reading a Hebrew Word template. something with the XSLT schema not converting the truefalse question type so well. I am still xdebugging it. hope to find a fix for it too)

ecampbell commented 7 years ago

Hi Nadav, I just fixed the qformat_wordtable plugin to properly import truefalse questions in Hebrew yesterday. Someone from the Open University in Israel noticed it too.

It would be great if you could mark the plugins you like as favourites in Moodle too.

nadavkav commented 7 years ago

The universe is much smaller than what most people think... That someone is my colleague (Yifat) ;-)

(Just marked them as favorites, thank you for pointing that out!)