search

ecaron / firefox-font-finder

Development area for the popular Firefox Font Finder add-on
https://addons.mozilla.org/en-us/firefox/addon/font-finder/
GNU General Public License v3.0
8 stars 7 forks source link

Combining two RPs #2

Closed andy-portmen closed 10 years ago

andy-portmen commented 10 years ago

Eric please take a look at my temporary branch https://github.com/andy-portmen/tmp

If it looks okay,merge it with yours.

andy-portmen commented 10 years ago

have you had a chance to take a look at this?

ecaron commented 10 years ago

Sorry, I misread your original email.

Would you feel comfortable submitting this as a PR to my repo? Seems like an excellent opportunity for us to practice that technique.

On Thu, Apr 24, 2014 at 12:08 AM, info-add0n notifications@github.comwrote:

have you had a chance to take a look at this?

— Reply to this email directly or view it on GitHubhttps://github.com/ecaron/firefox-font-finder/issues/2#issuecomment-41243162 .

inbasic commented 10 years ago

Combining two comments in one: (1) Isn't it easier if you add me as a collaborator first? Also make a beta channel as well. I think it is better if we push to this channel first. (2) aslo add Andy to the repo. as well. I just have a single bug fix commit. I can do a pull request if you guys prefer though.

inbasic commented 10 years ago

Guys do you want me to change the Github link to Eric's?

andy-portmen commented 10 years ago

@ecaron and @inbasic I haven't done any PR before...

andy-portmen commented 10 years ago

Guys do you want me to change the Github link to Eric's?

Not yet please. Let's combine the latest changes first.

inbasic commented 10 years ago

@andy-portmen I just sent you an email regarding the bug report. @ecaron there is no need to add me to the repo. anymore.

andy-portmen commented 10 years ago

https://github.com/ecaron/firefox-font-finder/pull/3