ecatch-kyst / web

IT Bachelor project @ NTNU ⚡🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

Feature/ui #27

Closed balazsorban44 closed 5 years ago

balazsorban44 commented 5 years ago

Before I opened this Pull Request, I have:

according to my best knowledge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #27 into develop will decrease coverage by 2.69%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #27     +/-   ##
==========================================
- Coverage    49.68%   46.99%   -2.7%     
==========================================
  Files           22       24      +2     
  Lines          161      183     +22     
  Branches        19       22      +3     
==========================================
+ Hits            80       86      +6     
- Misses          66       82     +16     
  Partials        15       15
Impacted Files Coverage Δ
src/components/Profile/LanguageChooser.jsx 66.66% <ø> (ø)
src/components/NotFound/index.js 33.33% <ø> (ø) :arrow_up:
src/lib/router.js 100% <ø> (ø) :arrow_up:
src/components/Register.jsx 46.15% <0%> (-3.85%) :arrow_down:
src/App.js 42.85% <0%> (-7.15%) :arrow_down:
src/db/actions/openModal.js 0% <0%> (ø)
src/components/Landing/index.js 0% <0%> (ø) :arrow_up:
src/components/Profile/index.js 100% <100%> (ø)
src/lib/i18next.js 100% <100%> (ø) :arrow_up:
src/lib/material-ui.js 100% <100%> (ø) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de9043c...009b7fc. Read the comment docs.

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 -
Performance 0 -
Progressive Web App 100 1
Accessibility 81 -
Best Practices 93 -

Tested with Lighthouse version: 4.1.0

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 -
Performance 0 -
Progressive Web App 100 1
Accessibility 81 -
Best Practices 93 -

Tested with Lighthouse version: 4.1.0