ecatch-kyst / web

IT Bachelor project @ NTNU ⚑🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

feature/ui #48

Closed balazsorban44 closed 5 years ago

balazsorban44 commented 5 years ago

Before I opened this Pull Request, I have:

according to my best knowledge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #48 into develop will decrease coverage by 5.17%. The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
- Coverage    44.06%   38.88%   -5.18%     
===========================================
  Files           44       44              
  Lines          413      414       +1     
  Branches        69       69              
===========================================
- Hits           182      161      -21     
- Misses         199      221      +22     
  Partials        32       32
Impacted Files Coverage Ξ”
src/components/shared/Notification.jsx 12% <7.69%> (-88%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update c4702e1...1489699. Read the comment docs.

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 0 -
Progressive Web App 100 90
Accessibility 81 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0