ecatch-kyst / web

IT Bachelor project @ NTNU ⚑🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

new logo/app name #60

Closed PetterRein closed 5 years ago

PetterRein commented 5 years ago

Before I opened this Pull Request, I have:

according to my best knowledge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #60 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #60   +/-   ##
========================================
  Coverage    42.36%   42.36%           
========================================
  Files           50       50           
  Lines          550      550           
  Branches       102      102           
========================================
  Hits           233      233           
  Misses         281      281           
  Partials        36       36
Impacted Files Coverage Ξ”
src/components/Landing/index.js 42.85% <ΓΈ> (ΓΈ) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 428c53b...8a69a9d. Read the comment docs.

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 46 -
Progressive Web App 96 90
Accessibility 72 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0

PetterRein commented 5 years ago

I'am checking the lighthouse 2 issues of 1 is a typo. Background is because I wrote 8 f's not 6 f's

But cannot fix: The page does not contain a heading, skip link, or landmark region Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently.

Failing Elements

html lang="en">

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 0 -
Progressive Web App 100 90
Accessibility 72 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 0 -
Progressive Web App 100 90
Accessibility 72 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 0 -
Progressive Web App 100 90
Accessibility 72 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0

toretefre commented 5 years ago

The page does not contain a heading, skip link, or landmark region

Looks like accessibility may be improved by introducing region landmarks or semantic HTML. However, i'm not sure whether this is within the scope of this PR? Check out https://www.w3.org/TR/wai-aria-practices/examples/landmarks/region.html for reference!

Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently.

I don't think this is relevant for our users, as our application mainly is being used on touch devices. If the accessibility score is impossible to reach without skip buttons, we may want to reduce our threshold score.

PetterRein commented 5 years ago

The page does not contain a heading, skip link, or landmark region

Looks like accessibility may be improved by introducing region landmarks or semantic HTML. However, i'm not sure whether this is within the scope of this PR? Check out https://www.w3.org/TR/wai-aria-practices/examples/landmarks/region.html for reference!

Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently.

I don't think this is relevant for our users, as our application mainly is being used on touch devices. If the accessibility score is impossible to reach without skip buttons, we may want to reduce our threshold score.

@balazsorban44 @toretefre

Figured out the reason for our lower Accessibility is because we now have a picture at Landing not a H4.

Look at Index.js in Landing Line 44. Do you know a fix Balazs?

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 82 1
Performance 0 -
Progressive Web App 100 90
Accessibility 83 80
Best Practices 100 80

Tested with Lighthouse version: 4.2.0