Closed balazsorban44 closed 5 years ago
Merging #71 into develop will increase coverage by
2.94%
. The diff coverage is36.78%
.
@@ Coverage Diff @@
## develop #71 +/- ##
===========================================
+ Coverage 39.42% 42.36% +2.94%
===========================================
Files 44 50 +6
Lines 416 550 +134
Branches 69 102 +33
===========================================
+ Hits 164 233 +69
- Misses 220 281 +61
- Partials 32 36 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/db/actions/user.js | 70.83% <ø> (ø) |
|
src/lib/i18next.js | 100% <ø> (ø) |
:arrow_up: |
src/App.js | 87.5% <ø> (ø) |
:arrow_up: |
src/lib/router.js | 100% <ø> (ø) |
:arrow_up: |
src/db/actions/messages.js | 0% <0%> (ø) |
:arrow_up: |
src/components/Forms/components/TextInput.jsx | 0% <0%> (ø) |
|
src/components/Messages/components/TableHead.jsx | 0% <0%> (ø) |
|
src/utils/firebase.js | 0% <0%> (ø) |
:arrow_up: |
src/components/Messages/components/Message.jsx | 0% <0%> (ø) |
|
src/components/Forms/components/Dropdown.jsx | 13.63% <0%> (-1.37%) |
:arrow_down: |
... and 20 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc2b858...894c410. Read the comment docs.
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 82 | 1 |
Performance | 0 | - |
Progressive Web App | 100 | 90 |
Accessibility | 81 | 80 |
Best Practices | 100 | 80 |
Tested with Lighthouse version: 4.2.0
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 82 | 1 |
Performance | 0 | - |
Progressive Web App | 100 | 90 |
Accessibility | 81 | 80 |
Best Practices | 100 | 80 |
Tested with Lighthouse version: 4.2.0
Before I opened this Pull Request, I have:
CHANGELOG.md
file 📝closes #38, closes #62
according to my best knowledge.