ecatch-kyst / web

IT Bachelor project @ NTNU ⚡🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

✨ Dark mode 🌃🔦 #9

Closed balazsorban44 closed 5 years ago

balazsorban44 commented 5 years ago

add both light ad dark themes for Material-UI (https://github.com/ecatch-kyst/web/blob/feature/dark-mode/src/lib/material-ui.js) NOTE: theming probably deserves its own issue.

Expected Behavior

When fishermen out on the sea in the middle of the night, it would be practical to provide a darker theme throughout the application.

SIDENOTE: It can also improve battery life.

Priority

Not important, but nice to have.

Size

2

balazsorban44 commented 5 years ago

@Mortefal could you propose a better Norwegian 🇳🇴 translation on line 14? https://github.com/ecatch-kyst/web/blob/66aea0932573841a6f5a2da1df22b65f8a1a37fd/src/locales/no/pages.json#L9-L16

Mortefal commented 5 years ago

@balazsorban44 How about: "Bytt til nattmodus for å gjøre det bedre å bruke appen om natten.", or something similar?

Mortefal commented 5 years ago

On the remaining option, that dark-mode should be enabled between 22 pm and 6 am, is this a feature we want to implement? Perhaps we can make it an option in "Advanced settings" or something similar.

balazsorban44 commented 5 years ago

Yep, not a priority at least. So it can wait.