Open sistux opened 6 months ago
I have already a running version and will make a pull request. Not finally, just started to remove xemacs code.
I don't know, if it is o.k. for you, but would it be possible to make first a branch ?
I would definitely suggest a branch first.
It seems I do not have the access rights to create a branch. Who can grant me the rights?
@tec-leo It's probably cleaner to have that branch on your fork and create a PR based on that. You can set the status to "draft" that way it is clear that it is a work in progress. At the same time, people with commit rights on this repository can also collaborate (i.e., push) to your branch.
thanks, I will try. any suggestions for the name of the fork and branch?
Your fork simply keeps the same name just under your username. i.e.: github.com/tec-leo/ecb
.
As for the branch name: I always tended to call issue/ticket related branches with txxx-TOPIC. So here I would do: t42-emacs29
. Just a suggestion really.
pull request is out.
@tec-leo I checked out your repo-branch and compiled it. for a while it works. Thanks! May be it would be nice to have the ecb-version update...
The only thing I've noted:
Error during redisplay: (eval (car (ecb-mode-line-make-modeline-str (format " W-%d" (1- (ecb-window-in-window-list-number (ecb-canonical-windows-list)))) ecb-mode-line-win-nr-face))) signaled (wrong-type-argument number-or-marker-p nil) [2 times]
maybe something in your modeline settings. Can you try if this works: '(mode-line-format '("" mode-line-modified mode-line-buffer-identification
(auto-composed t))
global-mode-string
#(" " 0 2
(auto-composed t))
leo-mark-flag
#("Line %l " 0 4
(auto-composed t))
#("Col %c " 0 5
(auto-composed t))
#(" %[(" 0 4
(auto-composed t))
mode-name minor-mode-alist "%n" mode-line-process
#(")%]----" 0 7
(auto-composed t))
(-3 . "%p")
#("-%-" 0 3
(auto-composed t))))
@tec-leo after I removed completely older emacs-bin-package (all related debian11-packages) the error message goes away. The string didn't worked, but I'm not sure if I it correctly.
For now looks ok for me, I will use emacs-29.2 with your changes in next days and give you a note.
Hi! Are there any plans to support it under 29.x? or are there some similar solutions? Thanks. Regards.