search

ecb-home / ecb

ECB Main Repository
Other
54 stars 11 forks source link

ECB advices for window management functions ignore Emacs Window Choices #8

Open metaturso opened 9 years ago

metaturso commented 9 years ago

I am using ECB 2.40.1 and I understand that this package advices some functions such as switch-to-buffer-other-window so that they always make change just to the edit window.

In practice those advices don't seem to respect the window choices dictated by Emacs configuration variables such as pop-up-frames or ns-popup-frames.

You can this with emacs -Q and the following bit of elisp:

(require 'ecb)
(ecb-activate)
(switch-to-buffer-other-window "*Messages*") ;; will cause a new frame to be opened.

Note: I'm currently using Emacs 25 on a Mac, but I have experienced this bug also on Emacs 24 still on the Mac.

ware commented 9 years ago

I'll take a look this coming weekend. Just to clarify, are you using Emacs 25 from MacPorts?

metaturso commented 9 years ago

Thanks @ware I appreciate.

To be fair I don't know if this is the one from MacPorts, all that I know is that I have used something along the lines of brew install emacs --HEAD --with-cocoa to install it.

I am currently using Emacs 25 but I have been experiencing the same problem since version 24.4, always on the Mac.

If I get some time tomorrow I'll run a test on the other version I have on a linux box and let you know.

metaturso commented 9 years ago

Sorry for not coming back to this for quite a some time.

I did test the same scenario on Emacs 24.4 on Ubuntu and it behaves just the same: new frames are opened regardless of my window choices setup.

metaturso commented 9 years ago

Good news, windows are finally behaving as expected. Apparently switching my git origin from emacs-mirror to this repository, and pulling the latest master (4cc1131d) fixed the issue as described above on Emacs 25.0.50.1 (from homebrew).

On the other hand, there are two snags that affect this version of the code. The first one still relates to window behaviour. When flymake-mode is enabled some buffers are opened in the compilation window regardless of ecb-other-window-behavior being set to 'only-edit.

The second one, relates to ECB in general, as I was unable to ecb-activate until I defined the variable stack-trace-on-error with some value in the global scope. The error is raised in ecb.el:1219.

ware commented 8 years ago

I'll look into it. That said, please keep in mind that Emacs 25.x is currently pre-release. The latest official release from GNU is 24.5. That said, I'll still look into it when I have time.

wrn commented 8 years ago

I am having the same issue. As of now, even with the latest master version here for ECB, still the same with Emacs 24.5.1 release. Will appreciate very much if someone can fix it, or even giving a temporary work around if a proper fix takes more time and consideration.