ecboghiu / inflation

Implementations of the Inflation Technique for Causal Inference.
GNU General Public License v3.0
22 stars 3 forks source link

Add momentequalities and momentinequalities #19

Open apozas opened 2 years ago

apozas commented 2 years ago

ncpol2sdpa has the ability of adding arbitrary (linear) constraints between elements of the moment matrix. Eventually we will want to implement something similar to improve the flexibility of the program. In fact, this is an easy way of imposing only some identifications with known probabilities.

EDIT: We have since long had the support for momentequalities and momentinequalities in the solveSDP_mosekFUSION, but several things need to be done before we can consider this a complete feature of the library:

eliewolfe commented 2 years ago

Looks like this is long since resolved.

apozas commented 2 years ago

I want to keep it open, because this feature is pretty crucial (given our new discoveries in non-network scenarios) and yet there does not exist tests for it. I think we should keep the issue open until proper tests are developed. Moreover, there is no simple way for a user to add them, and the export to other formats still does not support them.

apozas commented 2 years ago

No, since all the tasks here are not encompassed by #69. Moreover, albeit Task 1 can be delayed for after the first release, Task 2 is crucial for correctly handling non-networks and Task 3 is important for having a consistent package (I am happy dealing with this in the next coming days), and I think that both should be addressed before the initial release.