eccentricdevotion / TARDIS

A Spigot / Paper plugin for all Doctor Who fans - create and use a TARDIS! It's bigger on the inside!
GNU General Public License v3.0
79 stars 27 forks source link

New Library #808

Closed Airomis closed 4 months ago

Airomis commented 4 months ago

Describe the feature request

this room would work similar to a vault room but in tern store books both enchanted and wrote in.

I don't know how to sort the books between the bookshelves ( the bamboo ) but they should be stored in a way that books of the same type are in the same shelf

if a book is condensed via the atron condenser it will be placed in this room if the player has the room.

Describe alternatives you've considered

not really just thought an upgrade to the library would be nice with the new blocks

Airomis commented 4 months ago

if its possible if we mouse over a bookshelf it will tell us what type of enchanted book is there ( invisible item frame with a item that holds the name )

Airomis commented 4 months ago

2024-02-06_21 16 19

the light grey concrete should be able to change i think it would be wool blocks

eccentricdevotion commented 4 months ago

There are 118 different enchantments (39 types with levels from 1-5) Do you want a chiseled bookshelf for each one with a sign/item frame on it? Enchanted books can have more than one enchantment on them (potentially 118^4 = 193877776 combinations) - how do you sort them?

multiple enchants

Airomis commented 4 months ago

So what I was thinking is have a stack 1-5 tall where the bottom would be the level 1 then the 5th level 5 books this then makes it where you have to look at 39 Then the ones that only have 1 - 4 levels the normal bookshelves could be used to fill in the gaps

thus if you use the 4 walls like in the photo you get 8 missing enchantments that can be placed in the center of the room.

now for the combined books they can be placed with no sorting on shelves around the room. i placed the 8 extras in the center of the room.

now for the combined books you could have a central point that the 8 shelves go around and the books go in there.

now what i would also do is not restrict the sorting to only the hight level as higher level players wouldn't keep low level enchantments around. i would use a priority system.

1st look at the level and if the shelve is full then i would start to load from the lowest point first

or

just have a each stack just hold that type. so the stack would be marked sharpness and regardless of thhe level all the sharpness books go in that same shelf and fill from the bottom up

On Thu, Feb 8, 2024, 14:29 Eccentric Devotion @.***> wrote:

There are 118 different enchantments (39 types with levels from 1-5) Do you want a chiseled bookshelf for each one with a sign on it? Enchanted books can have more than one enchantment on them - how do you sort them?

— Reply to this email directly, view it on GitHub https://github.com/eccentricdevotion/TARDIS/issues/808#issuecomment-1934803092, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOUOQT4LGOSWNRB3XS2GDDYSURQ7AVCNFSM6AAAAABC4VUNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHAYDGMBZGI . You are receiving this because you authored the thread.Message ID: @.***>

eccentricdevotion commented 4 months ago

And what about multiple different enchantments in the same book?

Airomis commented 4 months ago

You could sort it on the highest level of enchant, or have the center of the room be a all other books.

Walls and outer ring would be for single types and the center tower could be the mixed books or even if you put the 2nd level have them stored up there where the current enchanting table is

On Thu, Feb 8, 2024, 21:08 Eccentric Devotion @.***> wrote:

And what about multiple different enchantments in the same book?

— Reply to this email directly, view it on GitHub https://github.com/eccentricdevotion/TARDIS/issues/808#issuecomment-1935231277, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOUOQQC573T4N7NSCJOETLYSWAKDAVCNFSM6AAAAABC4VUNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGIZTCMRXG4 . You are receiving this because you authored the thread.Message ID: @.***>

Airomis commented 4 months ago

I have a few days at work but I can take some photos on Monday of what I'm thinking after I get off

DaddyElf commented 4 months ago

Some enchants only have one level like silktouch and mending they could be combined in a stack. This is a really nice idea, keeping track of books is such a pain.

eccentricdevotion commented 4 months ago

library1 Labelled bookshelves for each level. Should I leave the extra chiseled shelves where the levels doesn't go up to 5... or fill them with normal bookshelves? library2

Airomis commented 4 months ago

The extra shelves could give room for extra books. Is it possible to put a normal shelve and have the block swapped when the chisled are about 75% full?

On Sun, Feb 11, 2024, 01:19 Eccentric Devotion @.***> wrote:

library1.jpg (view on web) https://github.com/eccentricdevotion/TARDIS/assets/1841924/21887ecb-5d33-4300-9157-eb6aa28fb6e7 Labelled bookshelves for each level. Should I leave the extra chiseled shelves where the levels doesn't go up to 5... or fill them with normal bookshelves? library2.jpg (view on web) https://github.com/eccentricdevotion/TARDIS/assets/1841924/d375973d-1877-4adf-b19d-d8de561b56d0

— Reply to this email directly, view it on GitHub https://github.com/eccentricdevotion/TARDIS/issues/808#issuecomment-1937445321, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOUOQWQDH5E42RYHHTHWELYTBPHZAVCNFSM6AAAAABC4VUNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGQ2DKMZSGE . You are receiving this because you authored the thread.Message ID: @.***>

Airomis commented 4 months ago

Whats the input? Is there a chest in the center of the room like a vault room?

On Sun, Feb 11, 2024, 01:46 Rocky Thompson @.***> wrote:

The extra shelves could give room for extra books. Is it possible to put a normal shelve and have the block swapped when the chisled are about 75% full?

On Sun, Feb 11, 2024, 01:19 Eccentric Devotion @.***> wrote:

library1.jpg (view on web) https://github.com/eccentricdevotion/TARDIS/assets/1841924/21887ecb-5d33-4300-9157-eb6aa28fb6e7 Labelled bookshelves for each level. Should I leave the extra chiseled shelves where the levels doesn't go up to 5... or fill them with normal bookshelves? library2.jpg (view on web) https://github.com/eccentricdevotion/TARDIS/assets/1841924/d375973d-1877-4adf-b19d-d8de561b56d0

— Reply to this email directly, view it on GitHub https://github.com/eccentricdevotion/TARDIS/issues/808#issuecomment-1937445321, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOUOQWQDH5E42RYHHTHWELYTBPHZAVCNFSM6AAAAABC4VUNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGQ2DKMZSGE . You are receiving this because you authored the thread.Message ID: @.***>

eccentricdevotion commented 4 months ago

Yes, drop chest in centre of the room

eccentricdevotion commented 4 months ago

I have enchanted books around the outside of the room and normal, writable, written and knowledge books in the centre (where the planks with ladders on were in the old library schematic)

Airomis commented 4 months ago

Great idea!

On Sun, Feb 11, 2024, 04:38 Eccentric Devotion @.***> wrote:

I have enchanted books around the outside of the room and normal, writable, written and knowledge books in the centre (where the planks with ladders on were in the old library schematic)

— Reply to this email directly, view it on GitHub https://github.com/eccentricdevotion/TARDIS/issues/808#issuecomment-1937493681, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOUOQUSZDR7CCVKWAVOBUTYTCGS5AVCNFSM6AAAAABC4VUNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGQ4TGNRYGE . You are receiving this because you authored the thread.Message ID: @.***>

Airomis commented 4 months ago

I was going to use a similar idea, only thing that I would have added was in each corner orlf the center box putting an armor stand or some type of decorative object

eccentricdevotion commented 4 months ago

Build 2797