eccentricdevotion / TARDIS

A Spigot / Paper plugin for all Doctor Who fans - create and use a TARDIS! It's bigger on the inside!
GNU General Public License v3.0
80 stars 27 forks source link

Auto-updates. #811

Closed MagmaBro123 closed 6 months ago

MagmaBro123 commented 7 months ago

Describe the feature request

Title. Rather then running /tadmin update_plugins, the plugin should, on reboot, auto-update itself. This is useful if admins aren't online to run the command. This can be toggled off via config.

Describe alternatives you've considered

N/A.

eccentricdevotion commented 7 months ago

Still going to require a server restart...

Chew commented 7 months ago

Auto updating should not be default, so it should be toggled on.

Also, this is quite expensive, having to check for a new updated build.. how often? When the plugin is disabled? Wouldn't that delay the shutdown process by downloading or checking for a JAR? Periodically would slam either Jenkins or GitHub which isn't entirely viable.

I think the command right now is good enough personally, maybe with a "You're out of date" notice on login like Essentials does.

MagmaBro123 commented 7 months ago

Auto updating should not be default, so it should be toggled on.

Also, this is quite expensive, having to check for a new updated build.. how often? When the plugin is disabled? Wouldn't that delay the shutdown process by downloading or checking for a JAR? Periodically would slam either Jenkins or GitHub which isn't entirely viable.

I think the command right now is good enough personally, maybe with a "You're out of date" notice on login like Essentials does.

Do what Slimefun does. Check and Update on startup.

DaddyElf commented 7 months ago

Slime fun still requires a reboot after updates are downloaded. I like the command to update as it is, slimefun only does auto updates if you started with a dev version. Some people don’t want to update till they test it out and make sure is doesn’t cause a problem first. Not saying Eccentric codes bad, he basically taught me Java, but interactions with other plugins is impossible to determine, too many variables.

MagmaBro123 commented 7 months ago

Rebooting isn't that hard.