search

eccentricdevotion / TARDIS

A Spigot / Paper plugin for all Doctor Who fans - create and use a TARDIS! It's bigger on the inside!
GNU General Public License v3.0
79 stars 27 forks source link

Chameleon Construct restrictions do not apply to the shell room #834

Closed techno156 closed 3 months ago

techno156 commented 3 months ago

Describe the bug

Players that use the shell room to build a TARDIS shell can use precious blocks to make one, even if allow.all_blocks is set to false, and prevents them from doing so using the Chameleon Construct GUI.

To Reproduce

  1. Grow Shell Room
  2. Set allow.all_blocks to false
  3. Create TARDIS out of precious blocks using the shell room constructor.

Screenshots

No response

Log files

N/A (Nothing pertinent on logs)

'/tardis version' output

[17:51:54 INFO]: [TARDIS] Server version: git-Paper-389 (MC: 1.20.4)
[17:51:54 INFO]: [TARDIS] TARDIS version: 5.5.0-b2829
[17:51:54 INFO]: [TARDIS] Checking for new TARDIS builds...
[17:51:54 INFO]: [TARDIS] You are running the latest version!
eccentricdevotion commented 3 months ago

Should the allow.all_blocks setting apply? If a player has gathered the resources to build a precious block exterior should they not be able to use it?

eccentricdevotion commented 3 months ago

I guess it should be consistent with the Chameleon Construct GUI though...

techno156 commented 3 months ago

Should the allow.all_blocks setting apply? If a player has gathered the resources to build a precious block exterior should they not be able to use it?

It does for the Construct GUI, which also takes the blocks from the player. Having the setting apply only if the player makes an exterior using the Construct UI, but not if they use the shell room seems odd, since it defeats the setting.

Particularly as unlike the shell room, the Construct GUI does not allow refunding of any precious blocks that go into it (unless that was the point of the setting).