search

eccentricdevotion / TARDIS

A Spigot / Paper plugin for all Doctor Who fans - create and use a TARDIS! It's bigger on the inside!
GNU General Public License v3.0
79 stars 27 forks source link

Crafting recipes not loading #847

Closed ToppanaFIN closed 1 week ago

ToppanaFIN commented 1 week ago

Describe the bug

After updating to 1.21, everything else seems to work with the tardis except crafting any tardis item. Console throws an error pasted below. Not sure what is causing this.

To Reproduce

Update to 1.21.

Screenshots

Capture Capture

Log files

Paste configs or pastebin.com link here!

https://pastebin.com/1vXsk8cM https://pastebin.com/wSZPWhHc

'/tardis version' output

[TARDIS]: Server version: 1.21-21-0a1b133 (MC: 1.21) [TARDIS]: TARDIS version: 5.7.0-b2862 [TARDIS]: Vault version: 1.7.3-b131 [TARDIS]: Multiverse-Core version: 4.3.12 [TARDIS]: Multiverse-Inventories version: 4.2.6 [TARDIS]: Essentials version: 2.21.0-dev+93-3a6fdd9 [TARDIS]: CoreProtect version: 22.4 [TARDIS]: Checking for new TARDIS builds... 13:40:26 [TARDIS]: You are running the latest version!

ToppanaFIN commented 1 week ago

Got rid of the error message by deleting outdated datapacks from world folder (oops). But the issue still remains, cannot craft tardis items

eccentricdevotion commented 1 week ago

I can't craft either... as far as I can tell the recipes are being added to the server, but I don't have time to do further checking until tomorrow...

eccentricdevotion commented 1 week ago

Seems to be a bug in Paper, but investigating further... custom-crafting-paper-vs-spigot

eccentricdevotion commented 1 week ago

Okay, so it's also a Spigot bug of some sort in that reloading datapacks causes recipes registered with Bukkit#addRecipe to be deleted - TARDIS tries to reload datapacks if it can't find the tardis:tardis advancement so it looks like the root of the issue is that the server is not loading the TARDIS datapack as the advancement is not found.

I'll remove the reloading for now until I find figure out the rest of the issue...

eccentricdevotion commented 1 week ago

Fixed now, for both Spigot and Paper. Build 2865