eccentricdevotion / TARDISWeepingAngels

Scary Doctor Who monsters for Spigot / Paper servers
5 stars 1 forks source link

weeping angels mobs bypass worldguard flags #7

Closed mrcoffee1026 closed 4 years ago

mrcoffee1026 commented 4 years ago

such as ability to damage blocks... the toclafane can destroy blocks despite settings and there's no way to disable "build" for these creatures as there is for other mobs. (build 132)

eccentricdevotion commented 4 years ago

For Toclafane explosion block damage what WorldGuard flag should it check for? CREEPER_EXPLOSION OTHER_EXPLOSION TNT BUILD All of the above Done Basically if any of them are set to deny then Toclafanes won't cause block damage (but the explosion effect will still happen). Could also add a config option as to whether explosions cause block damage or not. Done

eccentricdevotion commented 4 years ago

Should there be a check as to whether Judoon Guards can kill monsters in WorldGuard regions? Again what flag would need to be checked? There is a config option to disallow the guard feature, but it is server wide...

mrcoffee1026 commented 4 years ago

maybe the mob-griefing setting? Though I would leave this enabled since disabling it ruins villagers. Although if they only would attack hostiles I don't think it would be strictly necessary; if they would also attack passive creatures like cats and tamed wolves then yes... since I would disable their ability if they would be likely to kill people's pets.

eccentricdevotion commented 4 years ago

Judoon only target hostile mobs - Blaze, Cave Spider, Creeper, Drowned, Elder Guardian, Enderman, Endermite, Evoker, Guardian, Husk, Illager, Illusioner, Pig Zombie, Pillager, Raider, Ravager, Silverfish, Skeleton, Spider, Stray, Vex, Vindicator, Witch, Wither, Wither Skeleton, Zombie, Zombie Villager

mrcoffee1026 commented 4 years ago

Oh sorry I didn't see your first question... I think it should be checking either all or at least obeying the same rule as the worldguard global setting (not a flag): "block-creeper-block-damage: true" ... if this is set to true, then it should prevent toclafanes or other mobs from damaging blocks with explosions as well. Also the global setting "block-tnt-block-damage: true", it should follow this setting as well if it is using TNT for its explosion. Since the judoon are targeting hostile mobs it should be fine... if a player tries to keep a pet zombie or something they'll have to make appropriate precautions for such a thing well outside of the normal realm of say... putting a fence around some sheep for protection, so I wouldn't worry about it.

eccentricdevotion commented 4 years ago

As far as I know WorldGuard global settings just apply the region flags to the whole world - https://worldguard.enginehub.org/en/latest/regions/global-region/ So the checks for CREEPER_EXPLOSION, TNT should still work as expected. I'll do some checking

mrcoffee1026 commented 4 years ago

I'm familiar with the global-region but these are not independent flags in the region global, they are settings made in the config.yml. I'm not sure those settings are handled the same as flags as there are a lot of settings in there that can't be applied with flags... and any settings set in the config will override any flags set on a region as well.

mrcoffee1026 commented 4 years ago

for example the "tnt" flag inside a region... if set to deny would prevent a PLAYER from placing/using tnt... but if a mob (like one from another plugin I have which can be equipped with TNT capabilities) they would still be able to use TNT. I can set the flag "creeper-explosion" to deny for a region even in the "global" region, but allowing the explosion while preventing it from damaging blocks can only be done through that config setting.

eccentricdevotion commented 4 years ago

I've found it's easy enough to check the WG config, so will add the checks.

mrcoffee1026 commented 4 years ago

thank you so much!