RobertZenz
commented
6 years ago Mh, interesting, thanks for the detailed information. The plugin depends heavily upon the JDT infrastructure, which also includes that any class for decompilation is actually on the classpath. Requires a deeper look into it.
In the absence of any further instructions on the web page going to the output folder seems like the logical next step.
Personally, I would have accessed a referenced jar...could you please outline your use-case, I'd be very interested in hearing that one.
nickl-
Ok so my first instinct after installing the plugin is... lets go check out a class.
Problem/Issue
Cannot view project build class.
Where
Enhanced Class Decompiler (Core) 3.0.0.201709092115 Eclipse Version: Oxygen.1a Release (4.7.1a) Build id: 20171005-1200 Java: 1.8.0_144 OS: macOS High Sierra 10.13 Beta
Current results
When opening a project build class from the project output folder an error is displayed:
target/classes/package/name [in project-name] is not on its project's build path
Expected results
When opening any class the editor should work as advertised. Including decompiling, disassembly and byte code representations.
To reproduce
So the first thing I do after going through the settings, as explained on the web page, is to proceed to view a class in my newly installed class editor/viewer.
My first instinct, looking for a class to view is to find one in the project output folder. This folder, "Java output folders", is filtered by default so in "Project explorer" I open "Filters and Customisation" and uncheck the box next to "Java output folders". My m2e output folder target/classes becomes visible in the "Project explorer", but the default "build" folder would do the same, and I gain access to my project class files.
Double clicking on the first class I find does not however open the viewer but instead presents an error:
target/classes/package/name [in project-name] is not on its project's build path
A "Details" button reveals the following stack trace:
Result from attempting to follow instruction/information
Even though it makes no sense, if ever there was a build path for this project this is it, but none the less lets proceed to project's -> "Properties" -> "Java Build Path" and see. As expected attempting to add the target/classes folder on the "Source" tab results in an error
Source folder 'target/generated-sources/existing-import in project 'project-name' cannot output to distinct source folder 'target/classes'
Error which disables the "Apply" functionality to prevent any attempt to persist the conflict.
Conclusion
In the absence of any further instructions on the web page going to the output folder seems like the logical next step. Added to the fact that the aim of the project/plugin is to provide class viewer functionality, being unable to view my own classes is expected. I would even consider the default removal of the output folder filter to be acceptable installation configuration.
This seems like a simple enough thing to accomplish since the target is the solution to the problem, or in other words the build path which is missing is precisely what was selected. Perhaps it has to do with the output folder being prepended to the package name as in [output-folder]/[package-name] which causes the Class to be unrecognisable in the class path and maybe there could be a way to lookup this location adjust accordingly. Unfortunately I really have no idea what the impact is as I have zero eclipse plugin experience. Hope this report is informative enough for someone to find a quick solution.
More information on the web page, might also be a beneficial addition, instructing the new user on where they should go next to see the action, after browsing the settings. Also point out the additional menu items and context menu options available to assist in rapid adoption.
That said, this seems to be a very nice addition to my default Eclipse toolchain, it does seem like the decompilers are a tad dated but I notice others have commented on that already. All and all good work, well done and thank you!