search

ecdye / macSubtitleOCR

Convert bitmap subtitles into SubRip format using the macOS Vision framework
MIT License
14 stars 1 forks source link

build action #2

Closed systemcrash closed 2 months ago

systemcrash commented 2 months ago

Recommend this action to build binaries (unsigned are acceptable).

https://github.com/mxcl/xcodebuild

ecdye commented 2 months ago

Thanks for the suggestion. I will probably implement something like this at some point, but don't have plans to at the moment. If you would like to contribute a change adding this, I would be happy to review and merge a PR.

systemcrash commented 2 months ago

What xcode version is needed?

And min OS?

ecdye commented 2 months ago

Target OS is macOS 13 or newer. Minimum XCode version is 15

systemcrash commented 2 months ago

No joy. 

  xcodebuild: error: Unable to read project 'macSup2Srt.xcodeproj'.
    Reason: The project ‘macSup2Srt’ cannot be opened because it is in a future Xcode project file format (70). Adjust the project format using a compatible version of Xcode to allow it to be opened by this version of Xcode.

  exec: xcodebuild -destination platform=macOS -configuration Release -resultBundlePath build.xcresult build

Edit: Xcode 15.4.0

Attempt to open the project with Xcode locally, and I get Exception: didn't find classname for 'isa' key

Attempt to build from command line locally:

xcodebuild  build
Command line invocation:
    /Applications/Xcodenew.app/Contents/Developer/usr/bin/xcodebuild build

User defaults from command line:
    IDEPackageSupportUseBuiltinSCM = YES

2024-09-16 21:23:32.045 xcodebuild[56078:2411926] didn't find classname for 'isa' key
2024-09-16 21:23:32.049 xcodebuild[56078:2411926] Writing error result bundle to /var/folders/0n/m75p0t093mj45_f8mh6jvqdr0000gv/T/ResultBundle_2024-16-09_21-23-0032.xcresult
xcodebuild: error: Unable to read project 'macSup2Srt.xcodeproj'.
    Reason: The project ‘macSup2Srt’ is damaged and cannot be opened. Examine the project file for invalid edits or unresolved source control conflicts.

Path: /Users/paul/git/macSup2Srt/macSup2Srt.xcodeproj
Exception: didn't find classname for 'isa' key
ecdye commented 2 months ago

It might be because I was originally using Xcode 16, you could try with that

ecdye commented 2 months ago

Well, some things changed and I ended up making this a bit more of a priority so it should be fixed with 8e4628c. Thanks for bringing this up, sorry to bait and switch.

systemcrash commented 2 months ago

OK. Good that you tried. I also experimented a bit.

So you've managed to automate a build for arm64, but x86_64 is also important :)

I'm not sure about a predictable output directory, but I managed to pass various parameters to xcodebuild and get a predictable output by using at least

... -destination "platform=macOS,arch=$ARCH" install CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO DSTROOT="/Users/runner/work/macSup2Srt/macSup2Srt/Release"

Although I did this in a shell script, and not strictly in one of the github actions. The action you chose (I tried it also) doesn't support the destination parameter, I think.