:checkered_flag: prevent macro definitions

ecell / ecell4_base

An integrated software environment for multi-algorithm, multi-timescale, multi-spatial-representation simulation of various cellular phenomena

https://ecell4.e-cell.org/

GNU General Public License v3.0

63 stars 23 forks source link

:checkered_flag: prevent macro definitions #363

Closed ToruNiina closed 5 years ago

ToruNiina commented 5 years ago

to avoid name collision between ecell4::ReactionRule::STRICT and a macro named STRICT. Also it prevents min and max macro expansions that sometimes cause a weird error.

It shall hopefully resolve most of the compilation errors on Windows (but not link error).

ToruNiina commented 5 years ago

After some (local) discussion, we decided to solve some of the problems around this in a different way. I will make another PR soon.