:recycle: Wrap egfrd in namespace ecell4::egfrd

ecell / ecell4_base

An integrated software environment for multi-algorithm, multi-timescale, multi-spatial-representation simulation of various cellular phenomena

https://ecell4.e-cell.org/

GNU General Public License v3.0

62 stars 23 forks source link

:recycle: Wrap egfrd in namespace ecell4::egfrd #463

Closed ToruNiina closed 4 years ago

ToruNiina commented 4 years ago

related to #311.

add namespace ecell4 { namespace egfrd { to all the ecell4/egfrd/**.[hc]pp files.
rename ecell4::egfrd::EGFRDSimulator in egfrd.hpp that are used in python_api as ecell4::egfrd::DefaultEGFRDSimulator to avoid name collision

Note that, currently, no test that compares the trajectory has run. I will run it later.

ToruNiina commented 4 years ago

I ran the sample code, ecell4/egfrd/sample/mymapk, with a slight modification to dump the coordinates of particles. And I confirmed that there is no difference between master and egfrd-namespace.

ToruNiina commented 4 years ago

Azure says

##[warning]An image label with the label macOS-10.13 does not exist.
,##[error]The remote provider was unable to process the request.

It seems that OS X 10.13 has been removed from the supported OS. I will send a PR to update this.

https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops

ToruNiina commented 4 years ago

master:azure-pipelines.yml updated. restarting CI...