Closed noumantahir closed 2 years ago
@feruzm I love this suggestion, not just pasting link, we should also open a modal with title and url fields when user press add link button.
My second suggestion would be to make it easy for users to add link of images... I guess we do process video urls already but I tried pasting an image link and it just did not render the image instead just rendered tapable link.
@noumantahir yes, we can do so much more to make composing post more friendly. We had some design items in past.. let me see if I can find that, oh right we have them in App Stores screenshots... Check this out, how we imagined to show image links...
Alright let's discuss them during next meeting
In the mobile text editor, when a user pastes a link, you need to open a pop-up window, the same as when viewing a profile. In this window, make two fields, link text and link address. This will improve the user experience!
The other day I was writing a post on my iPad. It was excruciatingly difficult to paste the copied link in brackets!
Ref: https://discord.com/channels/385034494555455488/445901975301914624/943088021132165120
Implementation Strategy
After thinking on the use case a bit, it seems the most effective way to implement this feature would be to do it in phases...For instance phase one can be simple modal that inserts a link in post, later we can expand from that.
Phase 1
[label](url)
https:.....com
_handleOnSnippetReceived
[ref-1]with format text string ref-1: https://github.com/ecency/ecency-mobile/blob/5d991a49dd5d1f62858f29734f71865a31fccd22/src/components/markdownEditor/view/markdownEditorView.js#L268fyi: current applySnippet method adds leading and trailing
\n
(ref-2), to resolve this, remove them from applySnippet method but add that in Snippets modal before callinghandleOnSelect
[ref-3] fromSnippetsModal
ref-2:https://github.com/ecency/ecency-mobile/blob/5d991a49dd5d1f62858f29734f71865a31fccd22/src/components/markdownEditor/view/formats/applySnippet.ts#L5 ref-3:https://github.com/ecency/ecency-mobile/blob/5d991a49dd5d1f62858f29734f71865a31fccd22/src/components/snippetsModal/snippetsModal.tsx#L68Phase 2 If user selects a portion of text from post body before tapping link button,
Phase 3
Phase 4 User pastes a link, or shares a link from external app -- More details will add later