ecency / ecency-mobile

Ecency Mobile - reimagined social blogging, contribute and get rewarded (for Android and iOS)
https://ecency.com
MIT License
232 stars 69 forks source link

wrong table rendering.. #2292

Closed noumantahir closed 2 years ago

noumantahir commented 2 years ago

https://ecency.com/hive-193552/@gregory-f/actifit-gregory-f-20220509t012149809z

Screenshot Screenshot 2022-05-09 at 2 05 32 PM

noumantahir commented 2 years ago

@feruzm table is formatted in a way that header image is part of first row of columns and phone side html renderer reads that as first column instead of header.... web side however seems successfully distinguish well...

We cannot fix this issue on app side without changing the table html, which is not practical.... so our viable solutions are.

  1. Either we can fix such behaviour by updating RenderHTML component
  2. or use WebView for rendering tables, though we will lose of functionality that we gained with native rendering like image resizing etc.

Screenshot 2022-05-09 at 4 31 31 PM

Though web side seems to handle this pretty well, I would still mark it as a bug on Actifit side as their rest of headers use proper <tr> wrapping for header image...check their other well formed table below..

Screenshot 2022-05-09 at 4 44 15 PM

noumantahir commented 2 years ago

@feruzm Alright, after assessing our option of rendering web version of table, it seems going back to web is also not an option for us as it give rise to an issue that we resolved using native rendering...

Screenshot 2022-05-10 at 9 40 53 PM

It does however somewhat fixes the Actifit table rendering issue, but is it really worth going back to web rendering for this, I doubt that

Screenshot 2022-05-10 at 9 41 41 PM

It seems if we really want to fix this issue, our only option is to fork RenderHTML package and try to fix that issue from that, though it definitely not a walk in the park for certain.

What do you suggest....?

noumantahir commented 2 years ago

closed accidentally

noumantahir commented 2 years ago

There is one hack I can try, but it would not be solution in any way... we can check if post is from Actifit, and customise the table format to something that RenderHtml can easily interpret.

What we will have to do is turn this stranding image item into a first row for table.

Screenshot 2022-05-10 at 9 47 33 PM
feruzm commented 2 years ago

There is one hack I can try, but it would not be solution in any way... we can check if post is from Actifit, and customise the table format to something that RenderHtml can easily interpret.

What we will have to do is turn this stranding image item into a first row for table. Screenshot 2022-05-10 at 9 47 33 PM

If this is viable, I mean if they are consistently same formatting then yes I would agree, doing this minor tweak on actifit posts might do the job

noumantahir commented 2 years ago

There is one hack I can try, but it would not be solution in any way... we can check if post is from Actifit, and customise the table format to something that RenderHtml can easily interpret. What we will have to do is turn this stranding image item into a first row for table. Screenshot 2022-05-10 at 9 47 33 PM

If this is viable, I mean if they are consistently same formatting then yes I would agree, doing this minor tweak on actifit posts might do the job

giving it a shot