ecency / ecency-mobile

Ecency Mobile - reimagined social blogging, contribute and get rewarded (for Android and iOS)
https://ecency.com
MIT License
232 stars 69 forks source link

batch delete drafts #2724

Closed aliseyalvi closed 11 months ago

aliseyalvi commented 12 months ago

What does this PR?

added batch delete drafts and schedules functionality. User can longpress on a draft or schedule and a delete button would appear in header which delete multiple drafts selected in one go

Issue number

fixes #2676

Screenshots/Video

https://github.com/ecency/ecency-mobile/assets/48380998/8862b83e-3494-4937-8d14-ff8bfcea9207

aliseyalvi commented 11 months ago

https://github.com/ecency/ecency-mobile/assets/48380998/e8ea76fc-7d0a-4051-9000-8cc643be7ad8

noumantahir commented 11 months ago

Monosnap.screencast.2023-07-25.20-41-03.mp4

seems good, only change top delete button color to $pureWhite should work for both dark and light theme..

noumantahir commented 11 months ago

@aliseyalvi more feedback on this...

Long press draft entry delete button should also initiate batch delete selection process

If I delete a pre selected draft item, and then batch delete drafts, it throws a failure toast, which does not affect the functionality but confuses users..

Another feedback regarding selection mark, perhaps red border is still too much, may be make the draft entry delete button on red instead. tapping delete button to deselect should also fix the above mentioned issue.

Last, change top batch delete button icon color to white...

https://github.com/ecency/ecency-mobile/assets/6298342/c95df8c3-b684-4f89-947d-645bc36aef22

aliseyalvi commented 11 months ago

@noumantahir PR updated.

https://github.com/ecency/ecency-mobile/assets/48380998/48a2b7b8-7cca-41de-89b8-29f72a8930a8

noumantahir commented 11 months ago

@noumantahir PR updated.

Monosnap.screencast.2023-08-09.13-12-25.mp4

match color, if possible reuse this delete button as component and move it under components/atoms directory if not already there... if not smoothly possible just update color.

Screenshot 2023-08-09 at 1 52 20 PM

aliseyalvi commented 11 months ago

@noumantahir reverted delete icon color to primaryBlack as uploadGalleryModal is also using the same color

image image
aliseyalvi commented 11 months ago
image image