Closed feruzm closed 1 year ago
@feruzm Just updating, on the branch https://github.com/ecency/ecency-vision/tree/image-ratio-json-1156
And on the commit https://github.com/ecency/ecency-vision/commit/e17ce6a9fd13e7983333547ecc36913d228cda4b
I can currently get the width and height, but Javascript works in mysterious ways, so when it publishes to the blockchain the image_ratio goes as an empty array. I thought I was doing all the async magic correctly but I might be missing something. Will get back to this issue later with a fresh mind.
@feruzm it is working for the update function, I am working on the publish function and the save draft. Still need to figure out how to discern the uploaded ones.
Question: Why do we want those ratios? And why only uploaded and why only the first ones? Once uploaded I see no difference in the images that are uploaded and the ones that were added from external websites, they all are URLS in the metadata and the body
@igormuba from what I see, we are potentially loading images to get ratio. Initially I thought, we can get from uploaded images, but if we are loading all images anyway, best to add top 5-10 images and their ratio. Ratio we need on mobile app side and later on better image loading effect. If you know beforehand ratio or size of image, you can create nicer looking image loader that will cause minimal content shift which is highly recommended by google for seo purposes.
@feruzm I couldn't figure out how to gt the ratios from the uploaded images. On my last commit on the branch I limited to 5 images, it is going to save RC. I myself have plenty of RC to spend but I have friends that needed delegations and the less we put into the json metadata for those users the better
If any suggestions appear on how to get the ratios alternatively it is appreciated
During image uploads, we usually know ratio and size of image, width and height. Consider adding that info into content json metadata with new array, not all images maybe only top 5. Only uploaded images obviously, not linked images.