ecency / ecency-vision

Immutable, decentralized, uncensored, rewarding communities built, owned and operated by its users
https://ecency.com
MIT License
54 stars 55 forks source link

Bug: Drafts not saving payout type. #922

Closed feruzm closed 1 year ago

feruzm commented 2 years ago

use meta object field from api to save everything missing: payout type, beneficiaries, description, thumbnail, etc. And parse them when draft is opened again.

Relevant mobile app PR: https://github.com/ecency/ecency-mobile/pull/2356

MTSaeed commented 1 year ago

@feruzm I have tested and it seems to work already. I can see that Reward type is being save and retrieved properly. Please clarify if you mean to check the saving of existing fields on the drafts or adding new fields in the drafts that are there in the metadata but no input for them is there in drafts.

feruzm commented 1 year ago

@MTSaeed Please check if payout type is being send to backend inside meta json field and it is being set correctly when fetching and opening draft again. Some data we might be storing on localstorage, but we should be using backend api meta field.

MTSaeed commented 1 year ago

@feruzm I have noticed that payout type , beneficiaries, and all other data is send to backend at the time of adding the draft in the API and when drafts is load again it fetches the data from the backend API and show to the user. According to my understanding payout means rewardType. is it right or payout means anything else? Kindly verify. Thanks.

https://user-images.githubusercontent.com/106739598/230613278-f81d779e-44b0-43ad-869f-e988354ad227.mp4

feruzm commented 1 year ago

@MTSaeed yes that’s correct! In that case we can safely close this as it looks like outdated!