search

ecency / esteem-surfer

Ecency desktop formerly known as Esteem Surfer - reimagined desktop social wallet, contribute and get rewarded (for Windows, Mac, Linux)
https://ecency.com
MIT License
101 stars 30 forks source link

Close #204, #205 search improvement #206

Closed economicstudio closed 5 years ago

economicstudio commented 5 years ago

Close #204, #205

feruzm commented 5 years ago

Thanks @economicstudio for PR, looking good... Can I ask you to separate @ related change? Because that should probably be about finding accounts names and starting # should be about finding tags. Steem API has search for tags and accounts which can be utilized in this case and all other queries can use eSteem Search as usual. @talhasch please check this or work on separate PR with @economicstudio ...

economicstudio commented 5 years ago

@feruzm Thanks for your comment! Thanks for pointing out that, but actually esteem currently doesn't search people with @ as follows: It just returns the regular search result, which I actually prefer than user list. So does steemit.com

And if a user wanna still search with @, it can be wrapped by "" like on google :), (or just without @ at all) as follows:

So to me the current implementation is good (I truly believe there are many people who just wanna go back to someone's blog easily from search page), but let me know if you still prefer leave the search with @ as it was. Thanks!

feruzm commented 5 years ago

You can always use author and tag keywords for search.. Our search engine is quite advanced, we only need to show some tips for user when they start typing or when they type hint image

By using @, I was referring to autocomplete/autosuggestions rather than search, sorry I could've been more clearer. Once user select autocomplete options (search results from Steem API), we can navigate to user profile like you initially suggested. Same goes for # key, when autocomplete is selected, open example trending/#tag = trending/tag = trending/esteem. @talhasch will followup soon with his thoughts, I will ping him on discord...

talhasch commented 5 years ago

@economicstudio as @feruzm referred our search engine is very advanced and you can filter contents by author and tag filters. i could not clearly understand which side you wanted to improve? user filtering by username?

economicstudio commented 5 years ago

@feruzm Oh, I see. How can I enable autocomplete? It doesn't work for me and I can't find the option.

@talhasch my suggestion was, if people type @ned for instance, they want to go blog, not search result. Currently, search result doesn't even return the user with the same name on the top every time.

But if you guys just want the current behavior, that's fine, then I'll remove that commit and only leave 'toggle' function. So please let me know your decision. Thanks!

talhasch commented 5 years ago

@economicstudio currently we have username support for address bar. for example when you enter @ned to address bar and enter it takes you to @ned's blog.

Anyways, we decided to implement an auto complete functionality to address bar for users and tags. Closing this one. Thanks for your efforts&feedbacks.

feruzm commented 5 years ago

@economicstudio please leave only toggle functionality and we can merge that part for now.

economicstudio commented 5 years ago

@talhasch No problem, but you didn't understand my point. (I mean even in search mode, it should direct to blog, not search result) But anyway thanks for your comment and look forward to seeing the autocomplete feature :) Thanks.

@feruzm Thanks will do!