search

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.54k stars 175 forks source link

feat(icons): add `gitlab-ci.yml` #1026

Closed DrummyFloyd closed 1 week ago

DrummyFloyd commented 1 week ago

Because gitlab-ci.yml is a specific file used on gitlab for CI/CD stuff, i think should be cool to assume as mandatory in this libs =)

echasnovski commented 1 week ago

Thanks for the PR!

As GitHub has support, it might be reasonable to also add support for GitLab. Although the first one has directory support, and this is a file... I'll think about it.

DrummyFloyd commented 1 week ago

Thanks for the PR!

As GitHub has support, it might be reasonable to also add support for GitLab. Although the first one has directory support, and this is a file... I'll think about it.

yeah , the philosophy of github-actions actions is quite different, maybe it migh be a good idea to just put the github icons on github dir ?

EDIT: like you already did for the directory github ^^'

echasnovski commented 1 week ago

I am not sure what you mean here. '.github' is a directory and it should have "folder" like glyph. '.gitlab-ci.yml' is a file and should not have a "folder" like glyph ('nf-md-gitlab' is perfect).

DrummyFloyd commented 1 week ago

I am not sure what you mean here. '.github' is a directory and it should have "folder" like glyph. '.gitlab-ci.yml' is a file and should not have a "folder" like glyph ('nf-md-gitlab' is perfect).

nvm, i messed up my comment becasue meanwhile, i see that you already made a glyph for the .github/ dir https://github.com/echasnovski/mini.nvim/blob/12d275f4c3aeddfa12a758a69aff65090613ca34/lua/mini/icons.lua#L599

echasnovski commented 1 week ago

This now should be part of latest main. Thanks for the suggestion!