mini.files: Allow to open mini.files with terminal buffer

[David-Kunz]

Contributing guidelines

• [X] I have read CONTRIBUTING.md
• [X] I have read CODE_OF_CONDUCT.md
• [X] I have updated 'mini.nvim' to latest version

Module(s)

mini.files

Description

When opening mini.files with a terminal buffer, one gets the following error message:

E5108: Error executing lua (mini.files) `path` is not a valid path ("/<somePath>/Terminal 1")                                                                                                                                          
stack traceback:                                                                                                                                                                                                                          
        [C]: in function 'error'                                                                                                                                                                                                          
        ...023/.local/share/nvim/lazy/mini.files/lua/mini/files.lua:2642: in function 'error'                                                                                                                                             
        ...023/.local/share/nvim/lazy/mini.files/lua/mini/files.lua:708: in function 'open'                                                                                                                                               
        [string ":lua"]:1: in main chunk                                                                                                                                                                                                  
E21: Cannot make changes, 'modifiable' is off  

MiniFiles.open(vim.api.nvim_buf_get_name(0)) -- currently a terminal buffer

Suggestion: Open the current working directory instead (vim.fn.getcwd()).

Thanks, @echasnovski !

Neovim version

0.10.1

Steps to reproduce

1. :term
2. :lua MiniFiles.open(vim.api.nvim_buf_get_name(0))

Expected behavior

Opens vim.fn.getcwd() instead.

Actual behavior

Throws error

E5108: Error executing lua (mini.files) `path` is not a valid path ("/<somePath>/Terminal 1")                                                                                                                                          

[echasnovski]

Thanks for the suggestion!

This works as expected because open() is called not with existing on disk path. To open explorer in current directory, use either one of:

• MiniFiles.open().
• MiniFiles.open(vim.fn.getcwd()).
• Custom wrapper that checks if the the buffer is for the file and acts accordingly:

  _G.open_smart = function()
    local buf_name = vim.api.nvim_buf_get_name(0)
    local path = vim.fn.filereadable(buf_name) == 1 and buf_name or vim.fn.getcwd()
    add_to_log(path)
    MiniFiles.open(path)
  end

[David-Kunz]

Thank you, @echasnovski !