Don't highlight `@lsp.mod.defaultLibrary`

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort

MIT License

5.18k stars 187 forks source link

Don't highlight `@lsp.mod.defaultLibrary` #1301

Open wroyca opened 5 days ago

wroyca commented 5 days ago

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)

base16, hues

Description

@lsp.mod.defaultLibrary is very aggressive, and the logic behind what it considers to be from defaultLibrary seems almost arbitrary. In neovim/neovim#27929, it was agreed not to highlight it. Perhaps we should follow suit for both modules with mini?

echasnovski commented 5 days ago

Thanks for the suggestion!

In https://github.com/neovim/neovim/pull/27929, it was agreed not to highlight it.

The main point was that it was too aggressive for default color scheme. I still think that having Special color be used for anything "default" is a good idea in theory. If some LSP overuses it, it's bad. I'll take a further look beyond only C++.