Closed Reisen closed 1 year ago
Thanks for suggestion!
The current base16 module however (at least as I understood the docs) is geared towards termguicolors and only attempts to choose close color codes for cterm fallback, rather than providing the actual base16 color codes for a properly configured base16 terminal.
Yes, this sounds reasonably correct.
The suggested approach here is exactly as you have already done: supply use_cterm
as table with cterm
color codes that suit you best. It already can be both boolean or table, so I don't want to introduce another conditional logic to it.
Closing as not planned.
Contributing guidelines
Module(s)
base16
Description
I'm currently using the base16 mini module because it has a fairly comprehensive set of highlight rules for plugins that I rely on. However, I am using a base16 (256 color) theme for my terminal with termguicolors turned off, this gives me consistent colors accross all terminal applications.
The current base16 module however (at least as I understood the docs) is geared towards termguicolors and only attempts to choose close color codes for cterm fallback, rather than providing the actual base16 color codes for a properly configured base16 terminal.
I am working around this with something that is a bit of a hack:
The gui colors don't matter because I don't run in gui mode anyway so I set them all black, and the use_cterm being set to terminal color codes makes this code here properly assign the right terminal colors as I would have expected the defaults to be (see this base16-shell script example to see official the termcolor <-> base assigns).
With this I can change my terminal-wide theme and vim changes as expected (along with all other terminal apps). This seems like an intended way to use base16 in general so I wanted to see if this default base to termcolor map could be supported by the plugin itself, perhaps through
use_cterm = 'default'
or some other hint.