mini.starter(NIGHTLY NVIM): Doesn't properly update when downsizing

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort

MIT License

5.19k stars 187 forks source link

mini.starter(NIGHTLY NVIM): Doesn't properly update when downsizing #578

Closed ndavd closed 11 months ago

ndavd commented 11 months ago

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)

mini.starter

Description

Looks like it's not refreshing properly when resizing the window down.

Neovim version

NVIM v0.10.0-dev-1603+gac1113ded

Steps to reproduce

Just setup mini.starter with default config and scale the window up and then down.

Expected behavior

The screen should update properly

Actual behavior

It does not:

echasnovski commented 11 months ago

Thanks for the issue.

I can reproduce. This doesn't happen on Neovim 0.9.4, though. And judging by the effects, it seems to be some issue with Nightly. I'll look into it.

ndavd commented 11 months ago

Perfect, thanks!

echasnovski commented 11 months ago

I believe the root cause here is neovim/neovim#26139. There is a fix here, but it would lead to flickering on resize. As it is not a frequent event, it is acceptable, but we'll wait a bit for that to resolve.

echasnovski commented 11 months ago

As upstream issue is fixed, I can no longer reproduce it on latest Nightly and it seems to be fixed. Apart from query message disappearing (if was shown) after resize, but that is more or less aligned with not showing message on startup. Note for future: if want to fix that, wrap refresh call here invim.schedule. Right now this seems like an unnecessary change.