search

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.74k stars 179 forks source link

Update 'coc.nvim' to distinguish LSP 'unused parameter' highlight. #834

Closed wroyca closed 4 months ago

wroyca commented 4 months ago

Before:

Screenshot from 2024-04-23 13-13-44

Screenshot from 2024-04-23 13-16-40

After:

Screenshot from 2024-04-23 13-14-11

Screenshot from 2024-04-23 13-17-06

echasnovski commented 4 months ago

Thanks for the PR!

Do you think it might be better to define CocFadeOut as linked to 'Comment'? As CocUnusedHighlight is linked to it by default.

I am fine either way as I don't use 'coc.nvim' (anymore), more relying on your judgement here.

wroyca commented 4 months ago

Thanks for the PR!

Do you think it might be better to define CocFadeOut as linked to 'Comment'? As CocUnusedHighlight is linked to it by default.

I am fine either way as I don't use 'coc.nvim' (anymore), more relying on your judgement here.

Yes, sound reasonable, nice catch. Branch was force pushed to introduce CocFadeOut \:)

echasnovski commented 4 months ago

Thanks for the contribution! Much appreciated!