echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.54k stars 175 forks source link

fix(diff): update for breaking change on nightly #852

Closed gpanders closed 2 months ago

gpanders commented 2 months ago

https://github.com/neovim/neovim/pull/28101 renamed nvimbuf_redraw_range to nvimredraw.

echasnovski commented 2 months ago

Thanks for the PR!

Just noticed it couple of minutes ago :) In current form it will break earlier Neovim versions (as seen in CI). I would rather have a separate helper for the whole buffer (which is the only way it is used in 'mini.diff' right now) which uses the new vim.api.nvim__redraw() if it is present.

gpanders commented 2 months ago

Pulled out into a redraw_buffer helper. Let me know if any other changes are needed.

echasnovski commented 2 months ago

Pulled out into a redraw_buffer helper. Let me know if any other changes are needed.

Only style nit picking which I won't bother you with and will do myself. Thanks for the quick reaction!